problems running hello in fiasco

[Udo A. Steinberg]

On Tue, 1 Apr 2003 02:21:49 +0200 Fabian Sturm (FS) wrote:

FS> hmm I'm a bit confused about your fix. I didn't actually run it
FS> but from how I read this it still initializes the serial 
FS> console even if -noserial is given?

That's how I read it, too.

FS> shouldn't uart() be only called in the case -noserial is not given?
FS> So you must move the com line down a little bit more.

Yep, patch below.

-Udo.


Index: kdb.cpp
===================================================================
RCS file: /home/cvs/l4/kernel/fiasco/src/kern/kdb.cpp,v
retrieving revision 1.23
diff -u -1 -b -p -r1.23 kdb.cpp
--- kdb.cpp     31 Mar 2003 13:17:41 -0000      1.23
+++ kdb.cpp     1 Apr 2003 00:35:50 -0000
@@ -147,7 +147,4 @@ void kdb::init()
 
-  Uart *com = 0;
-
   if(strstr(cmdline, " -nokdb") || strstr(cmdline, " -noserial"))
     {
-      com = Kernel_uart::uart();
       disconnect();
@@ -156,3 +153,3 @@ void kdb::init()
     
-  
+  Uart *com = Kernel_uart::uart();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://os.inf.tu-dresden.de/pipermail/l4-hackers/attachments/20030401/7734585e/attachment-0001.sig>